Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[21321] Move Time_t to dds namespace and some *Attributes to xmlparser #5065

Merged
merged 8 commits into from
Jul 23, 2024

Conversation

Mario-DL
Copy link
Member

@Mario-DL Mario-DL commented Jul 12, 2024

Description

This PR:

  • Moves some *Attributes to eprosima::fastdds::xmlparser namespace
  • Splits Time_hpp in dds::Time_t and rtps::Time_t

Contributor Checklist

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • N/A If this is a critical bug fix, backports to the critical-only supported branches have been requested.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@Mario-DL Mario-DL added this to the v3.0.0 milestone Jul 12, 2024
@Mario-DL Mario-DL added the doc-pending Issue or PR which is pending to be documented label Jul 12, 2024
@Mario-DL Mario-DL changed the title [21321] Move Time_t to dds namespace and some *Attributes to xmlaparser [21321] Move Time_t to dds namespace and some *Attributes to xmlparser Jul 12, 2024
@Mario-DL Mario-DL removed the doc-pending Issue or PR which is pending to be documented label Jul 12, 2024
@Mario-DL Mario-DL force-pushed the feature/21321 branch 2 times, most recently from d542b54 to 3682409 Compare July 12, 2024 09:23
@github-actions github-actions bot added the ci-pending PR which CI is running label Jul 12, 2024
@Mario-DL Mario-DL requested review from EduPonz and removed request for richiprosima July 15, 2024 12:49
@elianalf elianalf added needs-review PR that is ready to be reviewed needs rebase and removed ci-pending PR which CI is running labels Jul 18, 2024
@Mario-DL Mario-DL requested review from MiguelCompany and removed request for EduPonz July 22, 2024 10:24
@github-actions github-actions bot added the ci-pending PR which CI is running label Jul 22, 2024
@Mario-DL Mario-DL requested review from MiguelCompany and removed request for MiguelCompany July 22, 2024 12:49
…:fastdds::xmlparser namespace

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
… eprosima::fastdds::dds::Time_t

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
src/cpp/utils/time_t_helpers.hpp Outdated Show resolved Hide resolved
src/cpp/utils/time_t_helpers.hpp Outdated Show resolved Hide resolved
src/cpp/utils/time_t_helpers.hpp Outdated Show resolved Hide resolved
src/cpp/utils/time_t_helpers.hpp Show resolved Hide resolved
src/cpp/fastdds/core/Time_t.cpp Outdated Show resolved Hide resolved
src/cpp/fastdds/core/Time_t.cpp Outdated Show resolved Hide resolved
versions.md Outdated Show resolved Hide resolved
Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
JesusPoderoso

This comment was marked as outdated.

@JesusPoderoso JesusPoderoso added ready-to-merge Ready to be merged. CI and changes have been reviewed and approved. and removed needs-review PR that is ready to be reviewed ci-pending PR which CI is running labels Jul 23, 2024
test/blackbox/api/dds-pim/PubSubReader.hpp Outdated Show resolved Hide resolved
test/blackbox/api/dds-pim/PubSubReader.hpp Outdated Show resolved Hide resolved
Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
Copy link
Contributor

@JesusPoderoso JesusPoderoso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
(check CI of this commit, commits since then have not changed building code)

@MiguelCompany MiguelCompany merged commit fec5777 into master Jul 23, 2024
3 checks passed
@MiguelCompany MiguelCompany deleted the feature/21321 branch July 23, 2024 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge Ready to be merged. CI and changes have been reviewed and approved.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants